zhijiangW commented on a change in pull request #8680: [FLINK-12706] Introduce
ShuffleService interface and its configuration
URL: https://github.com/apache/flink/pull/8680#discussion_r292336187
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleService.java
##########
@@ -18,18 +18,28 @@
package org.apache.flink.runtime.shuffle;
+import org.apache.flink.configuration.Configuration;
import org.apache.flink.runtime.io.network.api.writer.ResultPartitionWriter;
import org.apache.flink.runtime.io.network.partition.consumer.InputGate;
/**
* Interface for shuffle service implementations.
*
- * <p>This component is a light-weight factory for {@link ShuffleEnvironment}.
+ * <p>This component is a light-weight factory for {@link ShuffleMaster} and
{@link ShuffleEnvironment}.
*
+ * @param <SD> partition shuffle descriptor used for producer/consumer
deployment and their data exchange.
* @param <P> type of provided result partition writers
* @param <G> type of provided input gates
*/
-public interface ShuffleService<P extends ResultPartitionWriter, G extends
InputGate> {
+public interface ShuffleService<SD extends ShuffleDescriptor, P extends
ResultPartitionWriter, G extends InputGate> {
+
+ /**
+ * Factory method to create a specific {@link ShuffleMaster}
implementation in job master.
+ *
+ * @param configuration Flink configuration
+ * @return shuffle manager implementation
Review comment:
shuffle manager -> shuffle master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
