zhijiangW commented on a change in pull request #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration URL: https://github.com/apache/flink/pull/8680#discussion_r292328026
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleService.java ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.metrics.Gauge; +import org.apache.flink.metrics.MetricGroup; +import org.apache.flink.runtime.clusterframework.types.ResourceID; +import org.apache.flink.runtime.io.disk.iomanager.IOManager; +import org.apache.flink.runtime.io.network.buffer.NetworkBufferPool; +import org.apache.flink.runtime.io.network.netty.NettyConfig; +import org.apache.flink.runtime.io.network.netty.NettyConnectionManager; +import org.apache.flink.runtime.io.network.partition.ResultPartition; +import org.apache.flink.runtime.io.network.partition.ResultPartitionFactory; +import org.apache.flink.runtime.io.network.partition.ResultPartitionManager; +import org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate; +import org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateFactory; +import org.apache.flink.runtime.shuffle.ShuffleEnvironmentContext; +import org.apache.flink.runtime.shuffle.ShuffleService; +import org.apache.flink.runtime.taskmanager.NettyShuffleEnvironmentConfiguration; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * Netty based shuffle service implementation. + */ +public class NettyShuffleService implements ShuffleService<ResultPartition, SingleInputGate> { + + private static final String METRIC_GROUP_NETWORK = "Network"; + private static final String METRIC_TOTAL_MEMORY_SEGMENT = "TotalMemorySegments"; + private static final String METRIC_AVAILABLE_MEMORY_SEGMENT = "AvailableMemorySegments"; + + @Override + public NettyShuffleEnvironment createShuffleEnvironment(ShuffleEnvironmentContext shuffleEnvironmentContext) { + NettyShuffleEnvironmentConfiguration networkConfig = NettyShuffleEnvironmentConfiguration.fromConfiguration( + shuffleEnvironmentContext.getConfiguration(), + shuffleEnvironmentContext.getMaxJvmHeapMemory(), + shuffleEnvironmentContext.isLocalCommunicationOnly(), + shuffleEnvironmentContext.getHostAddress()); + return createNettyShuffleEnvironment( + networkConfig, + shuffleEnvironmentContext.getLocation(), + shuffleEnvironmentContext.getEventPublisher(), + shuffleEnvironmentContext.getParentMetricGroup(), + shuffleEnvironmentContext.getIOManager()); + } + + @VisibleForTesting + static NettyShuffleEnvironment createNettyShuffleEnvironment( + NettyShuffleEnvironmentConfiguration config, + ResourceID taskExecutorLocation, + TaskEventPublisher taskEventPublisher, + MetricGroup metricGroup, + IOManager ioManager) { + checkNotNull(ioManager); + checkNotNull(taskEventPublisher); + checkNotNull(config); + + NettyConfig nettyConfig = config.nettyConfig(); + + ResultPartitionManager resultPartitionManager = new ResultPartitionManager(); + + ConnectionManager connectionManager = nettyConfig != null ? + new NettyConnectionManager(resultPartitionManager, taskEventPublisher, nettyConfig, config.isCreditBased()) : + new LocalConnectionManager(); + + NetworkBufferPool networkBufferPool = new NetworkBufferPool( + config.numNetworkBuffers(), + config.networkBufferSize(), + config.networkBuffersPerChannel()); + + registerNetworkMetrics(metricGroup, networkBufferPool); + + ResultPartitionFactory resultPartitionFactory = new ResultPartitionFactory( + resultPartitionManager, + ioManager, + networkBufferPool, + config.networkBuffersPerChannel(), + config.floatingNetworkBuffersPerGate()); + + SingleInputGateFactory singleInputGateFactory = new SingleInputGateFactory( + taskExecutorLocation, + config, + connectionManager, + resultPartitionManager, + taskEventPublisher, + networkBufferPool); + + return new NettyShuffleEnvironment( + taskExecutorLocation, + config, + networkBufferPool, + connectionManager, + resultPartitionManager, + resultPartitionFactory, + singleInputGateFactory); + } + + private static void registerNetworkMetrics(MetricGroup metricGroup, NetworkBufferPool networkBufferPool) { + checkNotNull(metricGroup); Review comment: might remove this if this check could be done before in `createNettyShuffleEnvironment` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
