dawidwys commented on a change in pull request #8852:
[FLINK-12798][table-api][table-planner] Add a proper discover mechanism that
will enable switching between Flink & Blink Planner/Executor
URL: https://github.com/apache/flink/pull/8852#discussion_r299015509
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/AmbiguousTableFactoryException.java
##########
@@ -31,7 +31,7 @@
public class AmbiguousTableFactoryException extends RuntimeException {
// factories that match the properties
- private final List<TableFactory> matchingFactories;
+ private final List<?> matchingFactories;
Review comment:
This makes it easier to use with the subtypes of `TableFactory`, e.g. you
can pass `List<PlannerFactory>`. I changed it though to `List<? extends
TableFactory>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
