dawidwys commented on a change in pull request #8852:
[FLINK-12798][table-api][table-planner] Add a proper discover mechanism that
will enable switching between Flink & Blink Planner/Executor
URL: https://github.com/apache/flink/pull/8852#discussion_r299083106
##########
File path:
flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/scala/StreamTableEnvironment.scala
##########
@@ -247,40 +247,50 @@ object StreamTableEnvironment {
* The [[TableEnvironment]] for a Scala [[StreamExecutionEnvironment]] that
works with
* [[DataStream]]s.
*
- * A TableEnvironment can be used to:
- * - convert a [[DataStream]] to a [[Table]]
- * - register a [[DataStream]] in the [[TableEnvironment]]'s catalog
- * - register a [[Table]] in the [[TableEnvironment]]'s catalog
- * - scan a registered table to obtain a [[Table]]
- * - specify a SQL query on registered tables to obtain a [[Table]]
- * - convert a [[Table]] into a [[DataStream]]
- * - explain the AST and execution plan of a [[Table]]
- *
* @param executionEnvironment The Scala [[StreamExecutionEnvironment]] of
the TableEnvironment.
*/
def create(executionEnvironment: StreamExecutionEnvironment):
StreamTableEnvironment = {
- create(executionEnvironment, new TableConfig)
+ create(
+ executionEnvironment,
+ EnvironmentSettings.newInstance()
+ .useAnyPlanner()
+ .inStreamMode()
+ .build())
}
/**
* The [[TableEnvironment]] for a Scala [[StreamExecutionEnvironment]] that
works with
* [[DataStream]]s.
*
- * A TableEnvironment can be used to:
Review comment:
It's duplicated on the class level, but I'm ok with reverting that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
