dawidwys commented on a change in pull request #8852:
[FLINK-12798][table-api][table-planner] Add a proper discover mechanism that
will enable switching between Flink & Blink Planner/Executor
URL: https://github.com/apache/flink/pull/8852#discussion_r299073750
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/java/internal/StreamTableEnvironmentImpl.java
##########
@@ -114,11 +118,35 @@ public static StreamTableEnvironmentImpl create(
CatalogManager catalogManager,
TableConfig tableConfig,
StreamExecutionEnvironment executionEnvironment) {
+ return create(
+ catalogManager,
+ PlannerDescriptor.any().stream(),
+ tableConfig,
+ executionEnvironment);
+ }
+
+ /**
+ * Creates an instance of a {@link StreamTableEnvironment}. It uses the
{@link StreamExecutionEnvironment} for
+ * executing queries. This is also the {@link
StreamExecutionEnvironment} that will be used when converting
+ * from/to {@link DataStream}.
+ *
+ * @param catalogManager The {@link CatalogManager} to use for storing
and looking up {@link Table}s.
+ * @param tableConfig The configuration of the TableEnvironment.
+ * @param executionEnvironment The {@link StreamExecutionEnvironment}
of the TableEnvironment.
+ */
+ public static StreamTableEnvironmentImpl create(
Review comment:
I tried to "move/remove" most of them. I had to leave one here, as we need a
common root for both: `create(StreamExec, TableConfig)` & `create(StreamExec,
EnvSettings)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
