bowenli86 commented on a change in pull request #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#discussion_r302653177
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveFunctionDefinitionFactory.java ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.functions.hive; + +import org.apache.flink.api.java.typeutils.GenericTypeInfo; +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.catalog.CatalogFunction; +import org.apache.flink.table.catalog.config.CatalogConfig; +import org.apache.flink.table.catalog.hive.client.HiveShimLoader; +import org.apache.flink.table.catalog.hive.descriptors.HiveCatalogValidator; +import org.apache.flink.table.factories.FunctionDefinitionFactory; +import org.apache.flink.table.functions.AggregateFunctionDefinition; +import org.apache.flink.table.functions.FunctionDefinition; +import org.apache.flink.table.functions.ScalarFunctionDefinition; +import org.apache.flink.table.functions.TableFunctionDefinition; +import org.apache.flink.types.Row; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.ql.exec.UDAF; +import org.apache.hadoop.hive.ql.exec.UDF; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFEvaluator; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFResolver2; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDF; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDTF; +import org.apache.hadoop.mapred.JobConf; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.List; +import java.util.Map; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * Factory to create {@link FunctionDefinition} for Hive user defined functions. + */ +public class HiveFunctionDefinitionFactory implements FunctionDefinitionFactory { + private static final Logger LOG = LoggerFactory.getLogger(HiveFunctionDefinitionFactory.class); + + private final String hiveVersion; + + public HiveFunctionDefinitionFactory(HiveConf hiveConf) { + checkNotNull(hiveConf); + + this.hiveVersion = new JobConf(hiveConf).get(HiveCatalogValidator.CATALOG_HIVE_VERSION, HiveShimLoader.getHiveVersion()); + } + + @Override + public FunctionDefinition createFunctionDefinition(String name, CatalogFunction catalogFunction) { + + String functionClassName = catalogFunction.getClassName(); + + if (Boolean.valueOf(catalogFunction.getProperties().get(CatalogConfig.IS_GENERIC))) { + throw new TableException( + String.format("HiveFunctionDefinitionFactory does not support generic functions %s yet", name)); + } + + Class clazz; + try { + clazz = Thread.currentThread().getContextClassLoader().loadClass(functionClassName); + + LOG.info("Successfully loaded Hive udf '{}' with class '{}'", name, functionClassName); + } catch (ClassNotFoundException e) { + throw new TableException( + String.format("Failed to initiate an instance of class %s.", functionClassName), e); + } + + if (UDF.class.isAssignableFrom(clazz)) { + LOG.info("Transforming Hive function '{}' into a HiveSimpleUDF", name); + + return new ScalarFunctionDefinition( + name, + new HiveSimpleUDF(new HiveFunctionWrapper<>(functionClassName)) + ); + } else if (GenericUDF.class.isAssignableFrom(clazz)) { + LOG.info("Transforming Hive function '{}' into a HiveGenericUDF", name); + + return new ScalarFunctionDefinition( + name, + new HiveGenericUDF(new HiveFunctionWrapper<>(functionClassName)) + ); + } else if (GenericUDTF.class.isAssignableFrom(clazz)) { + LOG.info("Transforming Hive function '{}' into a HiveGenericUDTF", name); + + HiveGenericUDTF udtf = new HiveGenericUDTF(new HiveFunctionWrapper<>(functionClassName)); + + return new TableFunctionDefinition( + name, + udtf, + GenericTypeInfo.of(Row.class) + ); + } else if (GenericUDAFResolver2.class.isAssignableFrom(clazz)) { + LOG.info( + "Transforming Hive function '{}' into a HiveGenericUDAF with no UDAF bridging and Hive version %s", + name, hiveVersion); + + HiveGenericUDAF udaf = new HiveGenericUDAF(new HiveFunctionWrapper<>(functionClassName), false, hiveVersion); + + return new AggregateFunctionDefinition( + name, + udaf, + GenericTypeInfo.of(Object.class), + GenericTypeInfo.of(GenericUDAFEvaluator.AggregationBuffer.class) + ); + } else if (UDAF.class.isAssignableFrom(clazz)) { + LOG.info( + "Transforming Hive function '{}' into a HiveGenericUDAF with UDAF bridging and Hive version %s", + name, hiveVersion); + + HiveGenericUDAF udaf = new HiveGenericUDAF(new HiveFunctionWrapper<>(functionClassName), true, hiveVersion); + + return new AggregateFunctionDefinition( + name, + udaf, + GenericTypeInfo.of(Object.class), + GenericTypeInfo.of(GenericUDAFEvaluator.AggregationBuffer.class) + ); + } else { + throw new IllegalArgumentException( Review comment: Timo and I decided to limit the scope of function catalog features in 1.9.0 to be just reading hive functions. Please see our discussions above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
