bowenli86 commented on a change in pull request #8920: [FLINK-13024][table]
integrate FunctionCatalog with CatalogManager
URL: https://github.com/apache/flink/pull/8920#discussion_r302718636
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
##########
@@ -136,18 +185,19 @@ public void registerScalarFunction(String name,
ScalarFunction function) {
foundDefinition =
BuiltInFunctionDefinitions.getDefinitions()
.stream()
- .filter(f ->
normalizeName(name).equals(normalizeName(f.getName())))
+ .filter(f ->
functionName.equals(normalizeName(f.getName())))
.findFirst()
.map(Function.identity());
}
return foundDefinition.map(definition -> new
FunctionLookup.Result(
- ObjectIdentifier.of(defaultCatalogName,
defaultDatabaseName, name),
+ ObjectIdentifier.of(catalogManager.getCurrentCatalog(),
catalogManager.getCurrentDatabase(), name),
Review comment:
yes, that's a very good point. I will revert the path of in-memory and
built-in functions to its original behavior and follow up to see how to deal
with path of built-in functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
