bowenli86 commented on a change in pull request #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#discussion_r302684818
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java ########## @@ -56,6 +57,16 @@ return Optional.empty(); } + /** + * Get an optional {@link FunctionDefinitionFactory} instance that's responsible for generating function definitions + * for catalog functions in this catalog. + * + * @return an optional FunctionDefinitionFactory instance + */ + default Optional<FunctionDefinitionFactory> getFunctionDefinitionFactory() { Review comment: make sense. Side note: I wonder if we should have a better name for `Table`Factory in the near future. As far as I know, it's already used for table, catalog, and function. Though its javadoc describes itself as "A factory to create different table-related instances from string-based properties.", it's still quite confusing to developers - I myself frequently get confused by it and miss points like what you suggested, let alone those who are new and not familiar with this matter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services