twalthr commented on a change in pull request #9203: [FLINK-13375][table-api]
Move ExecutionConfigOptions and OptimizerConfigOptions to table-api
URL: https://github.com/apache/flink/pull/9203#discussion_r306336236
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -83,97 +83,97 @@
// Resource Options
//
------------------------------------------------------------------------
- public static final ConfigOption<Integer>
SQL_RESOURCE_DEFAULT_PARALLELISM =
- key("sql.resource.default.parallelism")
+ public static final ConfigOption<Integer>
TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM =
+ key("table.exec.resource.default-parallelism")
.defaultValue(-1)
.withDescription("Default parallelism
of job operators. If it is <= 0, use parallelism of
StreamExecutionEnvironment(" +
"its default value is
the num of cpu cores in the client host).");
- public static final ConfigOption<Integer>
SQL_RESOURCE_SOURCE_PARALLELISM =
- key("sql.resource.source.parallelism")
+ public static final ConfigOption<Integer>
TABLE_EXEC_RESOURCE_SOURCE_PARALLELISM =
+ key("table.exec.resource.source.parallelism")
.defaultValue(-1)
- .withDescription("Sets source
parallelism, if it is <= 0, use " + SQL_RESOURCE_DEFAULT_PARALLELISM.key() + "
to set source parallelism.");
+ .withDescription("Sets source
parallelism, if it is <= 0, use " +
TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM.key() + " to set source parallelism.");
- public static final ConfigOption<Integer> SQL_RESOURCE_SINK_PARALLELISM
=
- key("sql.resource.sink.parallelism")
+ public static final ConfigOption<Integer>
TABLE_EXEC_RESOURCE_SINK_PARALLELISM =
+ key("table.exec.resource.sink.parallelism")
.defaultValue(-1)
- .withDescription("Sets sink
parallelism, if it is <= 0, use " + SQL_RESOURCE_DEFAULT_PARALLELISM.key() + "
to set sink parallelism.");
+ .withDescription("Sets sink
parallelism, if it is <= 0, use " +
TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM.key() + " to set sink parallelism.");
- public static final ConfigOption<Integer>
SQL_RESOURCE_EXTERNAL_BUFFER_MEM =
- key("sql.resource.external-buffer.memory.mb")
- .defaultValue(10)
+ public static final ConfigOption<String>
TABLE_EXEC_RESOURCE_EXTERNAL_BUFFER_MEM =
+ key("table.exec.resource.external-buffer.memory")
+ .defaultValue("10 mb")
.withDescription("Sets the
externalBuffer memory size that is used in sortMergeJoin and overWindow.");
- public static final ConfigOption<Integer>
SQL_RESOURCE_HASH_AGG_TABLE_MEM =
- key("sql.resource.hash-agg.table.memory.mb")
- .defaultValue(128)
- .withDescription("Sets the table memory
size of hashAgg operator.");
+ public static final ConfigOption<String>
TABLE_EXEC_RESOURCE_HASH_AGG_TABLE_MEM =
+ key("table.exec.resource.hash-agg.memory")
+ .defaultValue("128 mb")
+ .withDescription("Sets the managed
memory size of hash aggregate operator.");
- public static final ConfigOption<Integer>
SQL_RESOURCE_HASH_JOIN_TABLE_MEM =
- key("sql.resource.hash-join.table.memory.mb")
- .defaultValue(128)
- .withDescription("Sets the HashTable
reserved memory for hashJoin operator. It defines the lower limit.");
+ public static final ConfigOption<String>
TABLE_EXEC_RESOURCE_HASH_JOIN_TABLE_MEM =
+ key("table.exec.resource.hash-join.memory")
+ .defaultValue("128 mb")
+ .withDescription("Sets the managed
memory for hash join operator. It defines the lower limit.");
- public static final ConfigOption<Integer> SQL_RESOURCE_SORT_BUFFER_MEM =
- key("sql.resource.sort.buffer.memory.mb")
- .defaultValue(128)
+ public static final ConfigOption<String>
TABLE_EXEC_RESOURCE_SORT_BUFFER_MEM =
+ key("table.exec.resource.sort.buffer.memory")
+ .defaultValue("128 mb")
.withDescription("Sets the buffer
memory size for sort.");
//
------------------------------------------------------------------------
// Agg Options
//
------------------------------------------------------------------------
- public static final ConfigOption<Integer>
SQL_EXEC_WINDOW_AGG_BUFFER_SIZE_LIMIT =
- key("sql.exec.window-agg.buffer-size-limit")
+ public static final ConfigOption<Integer>
TABLE_EXEC_WINDOW_AGG_BUFFER_SIZE_LIMIT =
+ key("table.exec.window-agg.buffer-size-limit")
.defaultValue(100 * 1000)
.withDescription("Sets the window
elements buffer size limit used in group window agg operator.");
//
------------------------------------------------------------------------
// Async Lookup Options
//
------------------------------------------------------------------------
- public static final ConfigOption<Integer>
SQL_EXEC_LOOKUP_ASYNC_BUFFER_CAPACITY =
- key("sql.exec.lookup.async.buffer-capacity")
+ public static final ConfigOption<Integer>
TABLE_EXEC_LOOKUP_ASYNC_BUFFER_CAPACITY =
+ key("table.exec.lookup.async.buffer-capacity")
.defaultValue(100)
.withDescription("The max number of
async i/o operation that the async lookup join can trigger.");
- public static final ConfigOption<String> SQL_EXEC_LOOKUP_ASYNC_TIMEOUT =
- key("sql.exec.lookup.async.timeout")
+ public static final ConfigOption<String>
TABLE_EXEC_LOOKUP_ASYNC_TIMEOUT =
+ key("table.exec.lookup.async.timeout")
.defaultValue("3 min")
.withDescription("The async timeout for
the asynchronous operation to complete.");
//
------------------------------------------------------------------------
// MiniBatch Options
//
------------------------------------------------------------------------
- public static final ConfigOption<Boolean> SQL_EXEC_MINIBATCH_ENABLED =
- key("sql.exec.mini-batch.enabled")
+ public static final ConfigOption<Boolean> TABLE_EXEC_MINIBATCH_ENABLED =
+ key("table.exec.mini-batch.enabled")
.defaultValue(false)
.withDescription("Specifies whether to
enable MiniBatch optimization. " +
"MiniBatch is an
optimization to buffer input records to reduce state access. " +
"This is disabled by
default. To enable this, users should set this config to true.");
- public static final ConfigOption<String>
SQL_EXEC_MINIBATCH_ALLOW_LATENCY =
- key("sql.exec.mini-batch.allow-latency")
+ public static final ConfigOption<String>
TABLE_EXEC_MINIBATCH_ALLOW_LATENCY =
+ key("table.exec.mini-batch.allow-latency")
.defaultValue("-1 ms")
.withDescription("The maximum latency
can be used for MiniBatch to buffer input records. " +
"MiniBatch is an
optimization to buffer input records to reduce state access. " +
"MiniBatch is triggered
with the allowed latency interval and when the maximum number of buffered
records reached. " +
- "NOTE: If " +
SQL_EXEC_MINIBATCH_ENABLED.key() + " is set true, its value must be greater
than zero.");
+ "NOTE: If " +
TABLE_EXEC_MINIBATCH_ENABLED.key() + " is set true, its value must be greater
than zero.");
- public static final ConfigOption<Long> SQL_EXEC_MINIBATCH_SIZE =
- key("sql.exec.mini-batch.size")
+ public static final ConfigOption<Long> TABLE_EXEC_MINIBATCH_SIZE =
+ key("table.exec.mini-batch.size")
.defaultValue(-1L)
.withDescription("The maximum number of
input records can be buffered for MiniBatch. " +
"MiniBatch is an
optimization to buffer input records to reduce state access. " +
"MiniBatch is triggered
with the allowed latency interval and when the maximum number of buffered
records reached. " +
- "NOTE: MiniBatch only
works for non-windowed aggregations currently. If " +
SQL_EXEC_MINIBATCH_ENABLED.key() +
+ "NOTE: MiniBatch only
works for non-windowed aggregations currently. If " +
TABLE_EXEC_MINIBATCH_ENABLED.key() +
" is set true, its
value must be positive.");
//
------------------------------------------------------------------------
// State Options
//
------------------------------------------------------------------------
- public static final ConfigOption<String> SQL_EXEC_STATE_TTL =
- key("sql.exec.state.ttl")
+ public static final ConfigOption<String> TABLE_EXEC_STATE_TTL =
+ key("table.exec.state.ttl")
Review comment:
`table.exec.state-ttl`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
