twalthr commented on a change in pull request #9203: [FLINK-13375][table-api]
Move ExecutionConfigOptions and OptimizerConfigOptions to table-api
URL: https://github.com/apache/flink/pull/9203#discussion_r306336919
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java
##########
@@ -56,33 +56,33 @@
"when there is data
skew in distinct aggregation and gives the ability to scale-up the job. " +
"Default is false.");
- public static final ConfigOption<Integer>
SQL_OPTIMIZER_DISTINCT_AGG_SPLIT_BUCKET_NUM =
- key("sql.optimizer.distinct-agg.split.bucket-num")
+ public static final ConfigOption<Integer>
TABLE_OPTIMIZER_DISTINCT_AGG_SPLIT_BUCKET_NUM =
+ key("table.optimizer.distinct-agg.split.bucket-num")
.defaultValue(1024)
.withDescription("Configure the number
of buckets when splitting distinct aggregation. " +
"The number is used in
the first level aggregation to calculate a bucket key " +
"'hash_code(distinct_key) % BUCKET_NUM' which is used as an additional group
key after splitting.");
- public static final ConfigOption<Boolean>
SQL_OPTIMIZER_REUSE_SUB_PLAN_ENABLED =
- key("sql.optimizer.reuse.sub-plan.enabled")
+ public static final ConfigOption<Boolean>
TABLE_OPTIMIZER_REUSE_SUB_PLAN_ENABLED =
+ key("table.optimizer.reuse.sub-plan.enabled")
Review comment:
`table.optimizer.reuse-sub-plan-enabled`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
