twalthr commented on a change in pull request #9203: [FLINK-13375][table-api]
Move ExecutionConfigOptions and OptimizerConfigOptions to table-api
URL: https://github.com/apache/flink/pull/9203#discussion_r306332190
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -41,40 +41,40 @@
//
------------------------------------------------------------------------
// Sort Options
//
------------------------------------------------------------------------
- public static final ConfigOption<Integer> SQL_EXEC_SORT_DEFAULT_LIMIT =
- key("sql.exec.sort.default.limit")
+ public static final ConfigOption<Integer> TABLE_EXEC_SORT_DEFAULT_LIMIT
=
+ key("table.exec.sort.default-limit")
.defaultValue(200)
- .withDescription("Default limit when
user don't set a limit after order by. ");
+ .withDescription("Default limit when
user don't set a limit after order by.");
- public static final ConfigOption<Integer>
SQL_EXEC_SORT_MAX_NUM_FILE_HANDLES =
- key("sql.exec.sort.max-num-file-handles")
+ public static final ConfigOption<Integer>
TABLE_EXEC_SORT_MAX_NUM_FILE_HANDLES =
+ key("table.exec.sort.max-num-file-handles")
.defaultValue(128)
.withDescription("The maximal fan-in
for external merge sort. It limits the number of file handles per operator. " +
"If it is too small,
may cause intermediate merging. But if it is too large, " +
"it will cause too many
files opened at the same time, consume memory and lead to random reading.");
- public static final ConfigOption<Boolean>
SQL_EXEC_SORT_ASYNC_MERGE_ENABLED =
- key("sql.exec.sort.async-merge.enabled")
+ public static final ConfigOption<Boolean>
TABLE_EXEC_SORT_ASYNC_MERGE_ENABLED =
+ key("table.exec.sort.async-merge.enabled")
Review comment:
`table.exec.sort.async-merge-enabled`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
