twalthr commented on a change in pull request #9203: [FLINK-13375][table-api]
Move ExecutionConfigOptions and OptimizerConfigOptions to table-api
URL: https://github.com/apache/flink/pull/9203#discussion_r306340168
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -83,97 +83,97 @@
// Resource Options
//
------------------------------------------------------------------------
- public static final ConfigOption<Integer>
SQL_RESOURCE_DEFAULT_PARALLELISM =
- key("sql.resource.default.parallelism")
+ public static final ConfigOption<Integer>
TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM =
+ key("table.exec.resource.default-parallelism")
.defaultValue(-1)
.withDescription("Default parallelism
of job operators. If it is <= 0, use parallelism of
StreamExecutionEnvironment(" +
"its default value is
the num of cpu cores in the client host).");
- public static final ConfigOption<Integer>
SQL_RESOURCE_SOURCE_PARALLELISM =
- key("sql.resource.source.parallelism")
+ public static final ConfigOption<Integer>
TABLE_EXEC_RESOURCE_SOURCE_PARALLELISM =
+ key("table.exec.resource.source.parallelism")
Review comment:
`source-parallelism`, `sink-parallelism`, `external-buffer-memory`,
`hash-agg-memory` etc.? A hierarchy with one child is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
