tillrohrmann commented on a change in pull request #9339: 
[FLINK-13555][runtime] SlotPool fails batch slot requests immediately if they 
are unfulfillable.
URL: https://github.com/apache/flink/pull/9339#discussion_r310644309
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
 ##########
 @@ -496,8 +495,7 @@ public void setFailUnfulfillableRequest(boolean 
failUnfulfillableRequest) {
                                        resourceActions.notifyAllocationFailure(
                                                pendingSlotRequest.getJobId(),
                                                
pendingSlotRequest.getAllocationId(),
-                                               new 
ResourceManagerException("Could not fulfill slot request " + 
pendingSlotRequest.getAllocationId() + ". "
-                                                       + "Requested resource 
profile (" + pendingSlotRequest.getResourceProfile() + ") is unfulfillable.")
+                                               new 
UnfulfillableSlotRequestException(pendingSlotRequest.getAllocationId(), 
pendingSlotRequest.getResourceProfile())
 
 Review comment:
   Great. Sorry I overlooked this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to