tillrohrmann commented on a change in pull request #9339:
[FLINK-13555][runtime] SlotPool fails batch slot requests immediately if they
are unfulfillable.
URL: https://github.com/apache/flink/pull/9339#discussion_r310551727
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/exceptions/UnfulfillableSlotRequestException.java
##########
@@ -31,4 +32,9 @@ public UnfulfillableSlotRequestException(PendingSlotRequest
pendingSlotRequest)
super("Could not fulfill slot request " +
pendingSlotRequest.getAllocationId() + ". "
+ "Requested resource profile (" +
pendingSlotRequest.getResourceProfile() + ") is unfulfillable.");
}
+
+ @VisibleForTesting
+ public UnfulfillableSlotRequestException() {
+ super("UnfulfillableSlotRequestException for testing purpose.");
+ }
Review comment:
Instead of introducing this constructor for tests only, I would change the
existing on to accept `UnfulfillableSlotRequestException(AllocationID,
ResourceProfile)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
