tillrohrmann commented on a change in pull request #9339:
[FLINK-13555][runtime] SlotPool fails batch slot requests immediately if they
are unfulfillable.
URL: https://github.com/apache/flink/pull/9339#discussion_r310535033
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -348,7 +349,7 @@ private void requestSlotFromResourceManager(
private void slotRequestToResourceManagerFailed(SlotRequestId
slotRequestID, Throwable failure) {
final PendingRequest request =
pendingRequests.getKeyA(slotRequestID);
if (request != null) {
- if (request.isBatchRequest) {
+ if (request.isBatchRequest && !(failure instanceof
UnfulfillableSlotRequestException)) {
Review comment:
Duplicate code. Better to factor it out into something like
`isBatchRequestAndFailureCanBeIgnored(request, failure)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
