tillrohrmann commented on a change in pull request #9339:
[FLINK-13555][runtime] SlotPool fails batch slot requests immediately if they
are unfulfillable.
URL: https://github.com/apache/flink/pull/9339#discussion_r310552395
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolBatchSlotRequestTest.java
##########
@@ -175,6 +204,28 @@ public void
testPendingBatchSlotRequestDoesNotFailIfRMRequestFails() throws Exce
}
}
+ /**
+ * Tests that a batch slot request fails if its resource manager
request fails with {@link UnfulfillableSlotRequestException}.
+ */
+ @Test
+ public void
testPendingBatchSlotRequestFailsIfRMRequestFailsUnfulfillable() throws
Exception {
+ final TestingResourceManagerGateway
testingResourceManagerGateway = new TestingResourceManagerGateway();
+
testingResourceManagerGateway.setRequestSlotFuture(FutureUtils.completedExceptionally(new
UnfulfillableSlotRequestException()));
+
+ final ComponentMainThreadExecutor directMainThreadExecutor =
ComponentMainThreadExecutorServiceAdapter.forMainThread();
+
+ final Time batchSlotTimeout = Time.milliseconds(1000L);
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
