godfreyhe commented on a change in pull request #9363:
[FLINK-13587][table-planner-blink] Fix some operator names are not set in blink
planner
URL: https://github.com/apache/flink/pull/9363#discussion_r310869591
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/FlinkRelNode.scala
##########
@@ -32,6 +34,18 @@ import scala.collection.JavaConversions._
*/
trait FlinkRelNode extends RelNode {
+ /**
+ * Returns the display name of the RelNode. The display name are usually
used to be displayed
+ * in log or Web UI.
+ */
+ def getDisplayName: String = {
Review comment:
i think this feature is belong to `ExecNode` and `getOperatorName` is
better. move this to a util class ?
another question: how to limit the length of the operator name ? if a
`SELECT` contains 500+ fields, the `Calc` name is very long
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
