godfreyhe commented on a change in pull request #9363:
[FLINK-13587][table-planner-blink] Fix some operator names are not set in blink
planner
URL: https://github.com/apache/flink/pull/9363#discussion_r312011790
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala
##########
@@ -306,28 +301,24 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
def doVerifyPlan(
sql: String,
- explainLevel: SqlExplainLevel,
withRowType: Boolean,
printPlanBefore: Boolean): Unit = {
doVerifyPlan(
sql = sql,
- explainLevel = explainLevel,
withRetractTraits = false,
withRowType = withRowType,
printPlanBefore = printPlanBefore)
}
def doVerifyPlan(
sql: String,
- explainLevel: SqlExplainLevel,
Review comment:
please do not delete the parameter, it's used for testing different kinds
plan, such as plan with cost (maybe those tests have not been ported until now)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
