godfreyhe commented on a change in pull request #9363:
[FLINK-13587][table-planner-blink] Fix some operator names are not set in blink
planner
URL: https://github.com/apache/flink/pull/9363#discussion_r312004763
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/calcite/Expand.scala
##########
@@ -82,14 +83,19 @@ abstract class Expand(
override def explainTerms(pw: RelWriter): RelWriter = {
val names = outputRowType.getFieldNames
- val terms = projects.map {
- project =>
- project.zipWithIndex.map {
- case (r: RexInputRef, i: Int) => s"${names.get(i)}=[${r.getName}]"
- case (l: RexLiteral, i: Int) => s"${names.get(i)}=[${l.getValue3}]"
- case (o, _) => s"$o"
- }.mkString("{", ", ", "}")
- }.mkString(", ")
+ val terms = if (pw.getDetailLevel == SqlExplainLevel.EXPPLAN_ATTRIBUTES) {
+ // improve the readability
+ getRowType.getFieldList.map(_.getName).mkString(", ")
Review comment:
use `names.mkString(", ")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
