tillrohrmann commented on a change in pull request #9364:
[FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in
CheckpointFailureManager
URL: https://github.com/apache/flink/pull/9364#discussion_r312356902
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -1097,6 +1107,16 @@ public void suspend(Throwable suspensionCause) {
}
}
+ public void failGlobal(Throwable cause, ExecutionAttemptID
failingAttempt) {
+ final Execution failedExecution =
currentExecutions.get(failingAttempt);
+ if (failedExecution != null && failedExecution.getState() ==
ExecutionState.RUNNING) {
+ failGlobal(cause);
+ } else {
+ LOG.warn("The failing attempt {} belongs to an already
not" +
Review comment:
Should not be a warning but debug log message since we expect this to happen
(without having negative side effects).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
