tillrohrmann commented on a change in pull request #9364:
[FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in
CheckpointFailureManager
URL: https://github.com/apache/flink/pull/9364#discussion_r312357325
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
##########
@@ -3910,10 +3928,18 @@ public void
jobFailsIfInFlightSynchronousSavepointIsDiscarded() throws Exception
// set up the coordinator and validate the initial state
final CheckpointCoordinator coordinator =
getCheckpointCoordinator(jobId, vertex1, vertex2,
- new CheckpointFailureManager(0, throwable -> {
- invocationCounterAndException.f0 += 1;
- invocationCounterAndException.f1 =
throwable;
- }));
+ new CheckpointFailureManager(
+ 0,
+ new
CheckpointFailureManager.FailJobCallback() {
+ @Override
+ public void failJob(Throwable
cause) {
+
invocationCounterAndException.f0 += 1;
+
invocationCounterAndException.f1 = cause;
+ }
+
+ @Override
+ public void
failJobDueToTaskFailure(Throwable cause, ExecutionAttemptID failingTask) {}
Review comment:
Let's throw an exception here to make sure that this method is not being
called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
