tillrohrmann commented on a change in pull request #9364:
[FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in
CheckpointFailureManager
URL: https://github.com/apache/flink/pull/9364#discussion_r312358245
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
##########
@@ -733,6 +733,51 @@ public void testFailureWhileRestarting() throws Exception
{
assertEquals(JobStatus.RUNNING, executionGraph.getState());
}
+ @Test
+ public void testFailingOfTheSameExecutionWhileRestarting() throws
Exception {
Review comment:
I think it would be nice if the test name states the unit under test, the
state and the expected outcome. E.g. it could be named
`failGlobalIfTaskIsStillRunning_failingAnExecutionTwice_ShouldTriggerOnlyOneFailover`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
