tillrohrmann commented on a change in pull request #9364: [FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in CheckpointFailureManager URL: https://github.com/apache/flink/pull/9364#discussion_r312356759
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ########## @@ -575,8 +575,18 @@ public void enableCheckpointing( checkpointStatsTracker = checkNotNull(statsTracker, "CheckpointStatsTracker"); CheckpointFailureManager failureManager = new CheckpointFailureManager( - chkConfig.getTolerableCheckpointFailureNumber(), - cause -> getJobMasterMainThreadExecutor().execute(() -> failGlobal(cause)) + chkConfig.getTolerableCheckpointFailureNumber(), + new CheckpointFailureManager.FailJobCallback() { + @Override + public void failJob(Throwable cause) { + getJobMasterMainThreadExecutor().execute(() -> failGlobal(cause)); + } + + @Override + public void failJobDueToTaskFailure(Throwable cause, ExecutionAttemptID failingTask) { + getJobMasterMainThreadExecutor().execute(() -> failGlobal(cause, failingTask)); Review comment: let's rename `failGlobal(Throwable, ExecutionAttemptId)` into `failGlobalIfTaskIsStillRunning` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services