pnowojski commented on a change in pull request #9383: [FLINK-13248] [runtime]
Adding processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r314322494
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
##########
@@ -251,4 +280,79 @@ public void quiesce() {
public State getState() {
return state;
}
+
+ @Override
+ public Mailbox getDownstreamMailbox(AbstractStreamOperator<?> operator)
{
+ return
getDownstreamMailbox(operator.getOperatorConfig().getChainIndex());
Review comment:
+1 for the @1u0 comment.
Dependency on `AbstractStreamOperator` is a very heavy one and will make
testing/reusing difficult. I would like to avoid it even with potential future
changes if `int priority` proves to be not enough. Keep in mind that we can
always refactor this in the future and using now `int priority` will not cause
us much (if any) overhead in the future if we need to change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
