pnowojski commented on a change in pull request #9383: [FLINK-13248] [runtime] 
Adding processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r314331799
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImplTest.java
 ##########
 @@ -123,70 +123,76 @@ public void testConcurrentPutTakeNonBlockingAndWait() 
throws Exception {
         */
        @Test
        public void testCloseUnblocks() throws InterruptedException {
-               testAllPuttingUnblocksInternal(Mailbox::close);
+               testAllPuttingUnblocksInternal(TaskMailbox::close);
                setUp();
-               testUnblocksInternal(() -> mailbox.takeMail(), Mailbox::close);
+               testUnblocksInternal(() -> taskMailbox.takeMail(), 
TaskMailbox::close);
        }
 
        /**
         * Test that silencing the mailbox unblocks pending accesses with 
correct exceptions.
         */
        @Test
        public void testQuiesceUnblocks() throws Exception {
-               testAllPuttingUnblocksInternal(Mailbox::quiesce);
+               testAllPuttingUnblocksInternal(TaskMailbox::quiesce);
        }
 
        @Test
        public void testLifeCycleQuiesce() throws Exception {
-               mailbox.putMail(() -> {});
-               mailbox.putMail(() -> {});
-               mailbox.quiesce();
+               taskMailbox.putMail(() -> {
+               });
 
 Review comment:
   optional nit: remove new line?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to