pnowojski commented on a change in pull request #9383: [FLINK-13248] [runtime] 
Adding processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r314315851
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
 ##########
 @@ -771,9 +773,11 @@ public void testClosingWithBlockedEmitter() throws 
Exception {
                MockEnvironment environment = createMockEnvironment();
 
                StreamTask<?, ?> containingTask = mock(StreamTask.class);
+               TaskMailboxImpl mailbox = new TaskMailboxImpl();
                when(containingTask.getEnvironment()).thenReturn(environment);
                when(containingTask.getCheckpointLock()).thenReturn(lock);
                when(containingTask.getProcessingTimeService()).thenReturn(new 
TestProcessingTimeService());
+               
when(containingTask.getTaskMailboxExecutor(any())).thenReturn(new 
MailboxExecutorImpl(mailbox));
 
 Review comment:
   arguably you are making this test worse by adding an extra mockito line here.
   
   You could try to replace it with `MockStreamTaskBuilder`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to