tillrohrmann commented on a change in pull request #9512:
[FLINK-13819][coordination] Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r317621795
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##########
@@ -137,18 +153,26 @@ public final void start() {
* @throws Exception indicating that the rpc endpoint could not be
started. If an exception occurs,
* then the rpc endpoint will automatically terminate.
*/
- public void onStart() throws Exception {}
+ public final void doStart() throws Exception {
Review comment:
Maybe let's rename this method into `internalCallOnStart` so that users see
that this method is an internal method. It is a bit unfortunate that with
Java's accessors we are not able to restrict the accessibility of this method
to only the `AkkaRpcActor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
