tillrohrmann commented on a change in pull request #9512:
[FLINK-13819][coordination] Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r317620473
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##########
@@ -158,7 +182,15 @@ protected final void stop() {
* @return Future which is completed once all post stop actions are
completed. If an error
* occurs this future is completed exceptionally
*/
- public CompletableFuture<Void> onStop() {
+ public final CompletableFuture<Void> doStop() {
Review comment:
Better to guard via `validateRunsInMainThread`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
