tillrohrmann commented on a change in pull request #9512:
[FLINK-13819][coordination] Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r317623777
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##########
@@ -127,7 +143,7 @@ public final void start() {
}
/**
- * User overridable callback.
+ * Starts the rpc endpoint.
Review comment:
This JavaDoc is misleading because the user might think that he needs to
call this method to start the `RpcEndpoint`. Better to say `Internal method
which is called by the RpcService implementation to start the RpcEndpoint` or
so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
