tillrohrmann commented on a change in pull request #9512:
[FLINK-13819][coordination] Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r317622851
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActorTest.java
##########
@@ -609,6 +611,7 @@ public void onStart() throws Exception {
public void awaitUntilOnStartCalled() throws
InterruptedException {
countDownLatch.await();
+ assertThat(getState(), is(State.STARTED));
Review comment:
Please don't piggy back on existing tests to check for the newly introduced
functionality. It is usually a better idea to add targeted tests for the new
behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
