zhuzhurk commented on a change in pull request #9663:
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r324502833
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerFactory.java
##########
@@ -66,14 +77,30 @@ public SchedulerNG createInstance(
jobMasterConfiguration,
slotProvider,
futureExecutor,
+ new ScheduledExecutorServiceAdapter(futureExecutor),
userCodeLoader,
checkpointRecoveryFactory,
rpcTimeout,
blobWriter,
jobManagerJobMetricGroup,
slotRequestTimeout,
shuffleMaster,
- partitionTracker);
+ partitionTracker,
+ schedulingStrategyFactory,
+ new RestartPipelinedRegionStrategy.Factory(),
Review comment:
It may be a bit out of scope for this PR, but I think we may need a failover
strategy factory loader to support multiple failover strategies.
And I'm also thinking to migrate the restart all strategy.
Restart all strategy may be useful we users want to job vertices to be all
running or no one running in some cases.
Besides, if we'd like to support single vertex restarting strategy in the
future, we may need an individual restart strategy, or just to support
pluggable failover strategy so that there is a way to do so.
This is out of the scope in this PR anyhow. I can work on it if we have
agreement to have it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
