zhuzhurk commented on a change in pull request #9663:
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r324526676
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1211,7 +1231,10 @@ private boolean processFail(Throwable t, boolean
isCallback, Map<String, Accumul
return false;
}
- if (transitionState(current, FAILED, t)) {
+ if (!isCallback && !isLegacyScheduling()) {
Review comment:
I think it's best is to avoid the DefaultScheduler and ExecutionGraph
notifying state changes to each other from the beginning.
We can let DefaultScheduler take full control of execution state changes.
And thus no need for the ExecutionGraph to notify the scheduler about it. This
requires a deep refactoring of current scheduling logics though, as mentioned
in [this
comment](https://github.com/apache/flink/pull/9663#pullrequestreview-288377060).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
