zhuzhurk commented on a change in pull request #9663: 
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r324593492
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerFactory.java
 ##########
 @@ -66,14 +77,30 @@ public SchedulerNG createInstance(
                        jobMasterConfiguration,
                        slotProvider,
                        futureExecutor,
+                       new ScheduledExecutorServiceAdapter(futureExecutor),
                        userCodeLoader,
                        checkpointRecoveryFactory,
                        rpcTimeout,
                        blobWriter,
                        jobManagerJobMetricGroup,
                        slotRequestTimeout,
                        shuffleMaster,
-                       partitionTracker);
+                       partitionTracker,
+                       schedulingStrategyFactory,
+                       new RestartPipelinedRegionStrategy.Factory(),
 
 Review comment:
   @tillrohrmann an individual restart strategy is needed if we want to only 
restart the failed task for recovery. Ot maybe just provide a pluggable way so 
that developer can do it out of flink core. Here's the 
[ML](https://lists.apache.org/thread.html/237de1061283a18dd813043a84d5d1debb15d1220368fa2f5b801025@%3Cdev.flink.apache.org%3E)
 for individual failover discussion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to