zhuzhurk commented on a change in pull request #9663: 
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r325636828
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ##########
 @@ -1179,11 +1197,19 @@ private void sendPartitionInfos() {
        //  Internal Actions
        // 
--------------------------------------------------------------------------------------------
 
+       private boolean isLegacyScheduling() {
+               return getVertex().isLegacyScheduling();
+       }
+
        private boolean processFail(Throwable t, boolean isCallback) {
                return processFail(t, isCallback, null, null, true);
        }
 
        private boolean processFail(Throwable t, boolean isCallback, 
Map<String, Accumulator<?, ?>> userAccumulators, IOMetrics metrics, boolean 
releasePartitions) {
 
 Review comment:
   This method is only invoked by `processFail(Throwable t, boolean 
isCallback)`.
   I think it's not needed anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to