zhuzhurk commented on a change in pull request #9663:
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r326487486
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverStrategyLoader.java
##########
@@ -44,13 +44,18 @@
/** Config name for the {@link RestartPipelinedRegionStrategy}. */
public static final String
LEGACY_PIPELINED_REGION_RESTART_STRATEGY_NAME = "region-legacy";
+ /** Config name for the {@link NoOpFailoverStrategy} */
+ public static final String NO_OP_FAILOVER_STRATEGY = "noop";
+
//
------------------------------------------------------------------------
/**
* Loads a FailoverStrategy Factory from the given configuration.
*/
public static FailoverStrategy.Factory
loadFailoverStrategy(Configuration config, @Nullable Logger logger) {
- final String strategyParam =
config.getString(JobManagerOptions.EXECUTION_FAILOVER_STRATEGY);
+ final String strategyParam =
config.getString(JobManagerOptions.SCHEDULER).equals("ng") ?
+ NO_OP_FAILOVER_STRATEGY :
Review comment:
How about a `ThrowingFailoverStrategy` here, just like
`ThrowingRestartStrategy`? We do not expect the strategy to be used after the
creation. `ThrowingFailoverStrategy` can help to found out potential issues.
We should use `isLegacyScheduling()` check to surround the
`failoverStrategy#notifyNewVertices` invocation in
`ExecutionGraph#attachJobGraph` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
