zhuzhurk commented on a change in pull request #9745: [FLINK-14070] [runtime]
Use TimeUtils to parse duration configs in flink-runtime
URL: https://github.com/apache/flink/pull/9745#discussion_r327002384
##########
File path:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala
##########
@@ -49,8 +51,6 @@ import scala.language.postfixOps
object AkkaUtils {
Review comment:
The parsing of akka configs are not replaced by TimeUtils.parseDuration(..),
since they are directly used for ActorSystem creation.
The only exception is "akka.ask.timeout" which is also widely used as Flink
RPC timeout config. So I parsed it with TimeUtils only when it is used by Flink
components (in AkkaUtils#getTimeout). It is still parsed by scala Duration when
used by akka (in AkkaUtils#getRemoteAkkaConfig).
The configs "akka.lookup.timeout" and "akka.client.timeout" are actually not
akka configs. They are only used by Flink components so the parsing logics for
them are updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
