zhuzhurk commented on a change in pull request #9745: [FLINK-14070] [runtime]
Use TimeUtils to parse duration configs in flink-runtime
URL: https://github.com/apache/flink/pull/9745#discussion_r327728832
##########
File path:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala
##########
@@ -49,8 +51,6 @@ import scala.language.postfixOps
object AkkaUtils {
Review comment:
I gave it a thought again and I think we can replace them.
The concern was that scala Duration supports infinite values like Inf, +Inf,
etc. Replacing the parsing may break jobs specifying infinite values. However,
since we never mentioned infinite durations in the config descriptors, I think
we can treat them as finite durations and throw errors for infinite values.
Besides that, do you think we should parse the other duration configs (e.g.
"akka.tcp.timeout") which were treated as string and directly set to Akka
configs? Parsing them can help to do an early check, rather than expecting Akka
to fail due to bad configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
