zhuzhurk commented on a change in pull request #9745: [FLINK-14070] [runtime]
Use TimeUtils to parse duration configs in flink-runtime
URL: https://github.com/apache/flink/pull/9745#discussion_r327762738
##########
File path:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala
##########
@@ -746,38 +744,17 @@ object AkkaUtils {
}
def getDefaultTimeout: Time = {
- val duration = Duration(AkkaOptions.ASK_TIMEOUT.defaultValue())
+ val duration =
TimeUtils.parseDuration(AkkaOptions.ASK_TIMEOUT.defaultValue())
Time.milliseconds(duration.toMillis)
}
- def getDefaultTimeoutAsFiniteDuration: FiniteDuration = {
- val timeout = getDefaultTimeout
-
- new FiniteDuration(timeout.toMilliseconds, TimeUnit.MILLISECONDS)
- }
-
- def getLookupTimeout(config: Configuration): FiniteDuration = {
- val duration = Duration(config.getString(AkkaOptions.LOOKUP_TIMEOUT))
-
- new FiniteDuration(duration.toMillis, TimeUnit.MILLISECONDS)
- }
-
- def getDefaultLookupTimeout: FiniteDuration = {
- val duration = Duration(AkkaOptions.LOOKUP_TIMEOUT.defaultValue())
- new FiniteDuration(duration.toMillis, TimeUnit.MILLISECONDS)
- }
-
- def getClientTimeout(config: Configuration): FiniteDuration = {
- val duration = Duration(config.getString(AkkaOptions.CLIENT_TIMEOUT))
-
- new FiniteDuration(duration.toMillis, TimeUnit.MILLISECONDS)
+ def getLookupTimeout(config: Configuration): time.Duration = {
+ return
TimeUtils.parseDuration(config.getString(AkkaOptions.LOOKUP_TIMEOUT))
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
