zhuzhurk commented on a change in pull request #9745: [FLINK-14070] [runtime]
Use TimeUtils to parse duration configs in flink-runtime
URL: https://github.com/apache/flink/pull/9745#discussion_r327762827
##########
File path:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala
##########
@@ -728,15 +728,13 @@ object AkkaUtils {
}
}
- def getTimeout(config: Configuration): FiniteDuration = {
- val duration = Duration(config.getString(AkkaOptions.ASK_TIMEOUT))
-
- new FiniteDuration(duration.toMillis, TimeUnit.MILLISECONDS)
+ def getTimeout(config: Configuration): time.Duration = {
+ return TimeUtils.parseDuration(config.getString(AkkaOptions.ASK_TIMEOUT))
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
