KarmaGYZ commented on a change in pull request #9801: [FLINK-13983][runtime]
Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r329346804
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -432,7 +432,12 @@ public static String getTaskManagerShellCommand(
tmParams.taskManagerDirectMemoryLimitMB()));
}
- startCommandValues.put("jvmmem", StringUtils.join(params, ' '));
+ final TaskExecutorResourceSpec taskExecutorResourceSpec =
tmParams.getTaskExecutorResourceSpec();
+ if (taskExecutorResourceSpec == null) { // FLIP-49 disabled
Review comment:
Just a side comment.
What if we check whether the FLIP-49 is enabled first? I think it could
decouple the switch of FLIP-49 from the value check of taskExecutorResourceSpec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
