KarmaGYZ commented on a change in pull request #9801: [FLINK-13983][runtime]
Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r329400418
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
##########
@@ -104,6 +113,11 @@ public TaskManagerServicesConfiguration(
boolean preAllocateMemory,
float memoryFraction,
int pageSize,
+ MemorySize taskHeapMemorySize,
+ MemorySize taskOffHeapMemorySize,
+ MemorySize shffuleMemorySize,
+ MemorySize onHeapManagedMemorySize,
+ MemorySize offHeapManagedMemorySize,
Review comment:
Maybe we could directly pass `taskExecutorResourceSpec ` to
`TaskManagerServicesConfiguration` or add a `Builder` for it? Since the
constructor takes too many parameters which easily become unwieldy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
