KarmaGYZ commented on a change in pull request #9801: [FLINK-13983][runtime]
Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r329344255
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -125,7 +125,7 @@ public static String generateDynamicConfigsStr(final
TaskExecutorResourceSpec ta
private static String assembleDynamicConfigsStr(final Map<String,
String> configs) {
final StringBuffer sb = new StringBuffer();
for (Map.Entry<String, String> entry : configs.entrySet()) {
-
sb.append("-D").append(entry.getKey()).append("=").append(entry.getValue()).append("
");
+ sb.append("-D
").append(entry.getKey()).append("=").append(entry.getValue()).append(" ");
Review comment:
What the purpose to change this format?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
