danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334319990
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -57,12 +60,15 @@
private final SqlNodeList propertyList;
+ @Nullable
Review comment:
Well, exactly, the `TableCreationContext` only was initialized when we
encounter the `(`. I think we can give a `SqlNodeList.EMPTY` as default value
for `primaryKeyList` and `uniqueKeysList` instead of null.
BTW, what is the use case for table without column definitions ? Can you
explain a little more ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
