danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table 
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334341019
 
 

 ##########
 File path: 
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
 ##########
 @@ -687,6 +687,18 @@ public void testCastAsRowType() {
                        "CAST(`A` AS ROW(`F0` VARCHAR NOT NULL, `F1` TIMESTAMP) 
MULTISET)");
        }
 
+       @Test
+       public void testValidateSqlCreateTable() {
+               String sql = "CREATE TABLE tbl1";
 
 Review comment:
   `SqlCreateTable` is a sql node name, we should avoid to use such name and 
use the sql term instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to