danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334781062
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateView.java
##########
@@ -54,9 +61,9 @@ public SqlCreateView(
boolean replace,
SqlCharStringLiteral comment) {
super(OPERATOR, pos, replace, false);
- this.viewName = viewName;
- this.fieldList = fieldList;
- this.query = query;
+ this.viewName = requireNonNull(viewName, "View name is
missing");
+ this.fieldList = requireNonNull(fieldList, "FieldList should
not be null");
+ this.query = requireNonNull(query, "Query is missing");
Review comment:
`FieldList` is not a valid noun or verb.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
