danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334774864
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -57,12 +60,15 @@
private final SqlNodeList propertyList;
+ @Nullable
Review comment:
No, can we make the `primaryKeyList` and `uniqueKeysList` default as
`SqlNodeList.EMPTY` instead of null ? So that in `SqlCreateTable`, we can mark
them as 'requireNotNull'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
