hequn8128 commented on a change in pull request #9969: 
[FLINK-14022][table-planner][table-planner-blink] Add validation check for 
places where Python ScalarFunction cannot be used
URL: https://github.com/apache/flink/pull/9969#discussion_r339872658
 
 

 ##########
 File path: 
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/expressions/utils/userDefinedScalarFunctions.scala
 ##########
 @@ -376,6 +376,28 @@ class SplitUDF(deterministic: Boolean) extends 
ScalarFunction {
   override def isDeterministic: Boolean = deterministic
 }
 
+class PythonScalarFunction(name: String) extends ScalarFunction {
 
 Review comment:
   If we have them here, we can remove the two classes in 
`PythonCalcSplitRuleTest` to avoid code duplication.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to