hequn8128 commented on a change in pull request #9969:
[FLINK-14022][table-planner][table-planner-blink] Add validation check for
places where Python ScalarFunction cannot be used
URL: https://github.com/apache/flink/pull/9969#discussion_r339954394
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala
##########
@@ -342,7 +342,9 @@ object FlinkStreamRuleSets {
PythonCalcSplitRule.SPLIT_CONDITION,
PythonCalcSplitRule.SPLIT_PROJECT,
PythonCalcSplitRule.PUSH_CONDITION,
- PythonCalcSplitRule.REWRITE_PROJECT
+ PythonCalcSplitRule.REWRITE_PROJECT,
+ // Rule that splits python ScalarFunctions from join conditions
+ SplitPythonConditionFromJoinRule.INSTANCE
Review comment:
We should put this rule before the `PythonCalcSplitRule` as the condition in
Calc may also need to be split. The plan test has already refected this
error(in `SplitPythonConditionFromJoinRuleTest`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
