hequn8128 commented on a change in pull request #9969: 
[FLINK-14022][table-planner][table-planner-blink] Add validation check for 
places where Python ScalarFunction cannot be used
URL: https://github.com/apache/flink/pull/9969#discussion_r341448064
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala
 ##########
 @@ -326,6 +326,8 @@ object FlinkStreamRuleSets {
     * RuleSet to do rewrite on FlinkLogicalRel for Stream
     */
   val LOGICAL_REWRITE: RuleSet = RuleSets.ofList(
+    // Rule that splits python ScalarFunctions from join conditions
+    SplitPythonConditionFromJoinRule.INSTANCE,
 
 Review comment:
   Put it to a place which close with the other python rules. i.e., put it 
before `FlinkCalcMergeRule`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to