wsry commented on a change in pull request #9993:
[FLINK-14498][runtime]Introduce NetworkBufferPool#isAvailable() for interacting
with LocalBufferPool.
URL: https://github.com/apache/flink/pull/9993#discussion_r340522208
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
##########
@@ -142,14 +150,16 @@ public NetworkBufferPool(
@Nullable
public MemorySegment requestMemorySegment() {
- return availableMemorySegments.poll();
+ synchronized (availabilityHelper) {
+ return internalRequestMemorySegment();
+ }
}
public void recycle(MemorySegment segment) {
// Adds the segment back to the queue, which does not
immediately free the memory
// however, since this happens when references to the global
pool are also released,
// making the availableMemorySegments queue and its contained
object reclaimable
- availableMemorySegments.add(checkNotNull(segment));
+ internalRecycle(Collections.singleton(checkNotNull(segment)));
Review comment:
Agree that the overhead could be ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
